Skip to content

Commit

Permalink
Missed PHP setup step in benchmark workflow (#154)
Browse files Browse the repository at this point in the history
Integration of step to setup PHP version 8.3 in the benchmark workflow
process has been added. This setup step ensures correct PHP version is
used before running benchmarks. This modification has been implemented
in both active and commented sections of the GitHub workflow.
  • Loading branch information
SmetDenis committed Apr 8, 2024
1 parent ff5c876 commit ae5aa22
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ jobs:
fetch-depth: 0
ref: ${{ github.event.inputs.branch || github.ref }}

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.3

# We need it to build benchmark tool. See ./tests/Benchmarks
- name: Build project
run: make build --no-print-directory
Expand Down Expand Up @@ -82,6 +87,11 @@ jobs:
# uses: shivammathur/setup-php@v2
# with:
# php-version: 8.3
#
# - name: Setup PHP
# uses: shivammathur/setup-php@v2
# with:
# php-version: 8.3
# coverage: none
# ini-values: opcache.enable_cli=1, opcache.jit=1255
#
Expand Down

0 comments on commit ae5aa22

Please sign in to comment.