Init #1
Merged
Init #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
March 10, 2024 15:00
…ptions and update test cases.
- Updated CSV structure definition in full.yml - Refactored error message concatenation in Error.php - Renamed UnitFacing validator to CardinalDirection - Updated ValidateFile command description
…ser.json - Add full CSV schema examples in YAML, JSON, and PHP formats - Update jbzoo/toolbox-dev to version 7.1 and add jbzoo/markdown to composer.json
Add spoiler functionality to README.md in order to show different file formats. This includes adding the PHP array as file, JSON format, and PHP code as spoilers. Also refactor the MiscTest.php to use a private helper method for generating spoiler.
…ats. Fix testCheckYmlSchemaExampleInReadme method to match updated title. Fix messages in MiscTest.
Refactored CSV validation methods to use ErrorSuite for better error handling and reporting. Updated validation logic for specific rules like min, max, regex, and format to provide more descriptive error messages. Updated the CsvFile's validate method to return an ErrorSuite.
- Refactor CsvFile constructor to improve readability by separating assignment statements for schema, structure, and reader. - Add new methods to ErrorSuite for counting errors and retrieving error by index.
Fix typo in the file paths for schema examples in MiscTest.php tests to point to the correct file location.
…lay error messages with details. If no errors are found, display "Looks good!" message.
Renamed workflow from "CI" to "Demo" to emphasize its focus on demonstrating features and use cases. Removed outdated or unused configuration options from the workflow file. Cleaned up commands and added a new command to run demo for GitHub. Updated README, composer.json, and other related files to reflect the changes being made to the workflow.
- Changed the make update command to remove --no-print-directory option for standard output consistency.
added 3 commits
March 11, 2024 01:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.