Refactor benchmark setup and enhance CSV generation logging #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor splits the benchmark setup into two separate jobs for better handling of individual configurations: one for Docker-based benchmarks and another for PHP-based benchmarks. The jobs now support testing with varying numbers of columns. In addition, the CSV generation process now includes better-riched logs for easier debugging.
Pull Request Test Coverage Report for Build 8485840239Details
💛 - Coveralls |
This change allows the value of BENCH_COLS to be overridden from the environment. If BENCH_COLS isn't set in the environment, its value defaults to 10. Thus, this improvement provides more flexibility in setting up the benchmark tests.
The BENCH_COLS variable now takes the value from the Github Actions strategy matrix. The default value in the Makefile has also been changed to 10. This allows for better control and flexibility in setting up the benchmark tests.
Updated the benchmark job names from "via Docker" to "Docker" and from "via PHP" to "Phar" for better clarity. Also, adjusted all references from PHAR to Phar in workflows and Makefile for consistency. BigInteger
Updated the benchmark job names from "via Docker" to "Docker" and from "via PHP" to "Phar" for better clarity. Also, adjusted all references from PHAR to Phar in workflows and Makefile for consistency. BigInteger
Made improvements to the .github/workflows/benchmark.yml file. Restructured job names and actions for clarity, and updated the rules for handling local and latest versions of Phar files.
Made improvements to the .github/workflows/benchmark.yml file. Restructured job names and actions for clarity, and updated the rules for handling local and latest versions of Phar files.
The changes in the .github/workflows/benchmark.yml file include updating the reference to use github.event.inputs.branch instead of github.event.pull_request.head.ref. Additionally, the command to build local Phar file has been modified and now includes running the built php archive file.
The changes in the .github/workflows/benchmark.yml file include updating the reference to use github.event.inputs.branch instead of github.event.pull_request.head.ref. Additionally, the command to build local Phar file has been modified and now includes running the built php archive file.
Renamed the workflow from 'Stress Test' to 'Speed Test' in benchmark.yml. Also, unnecessary triggers like Pull Request and Release have been removed to clean up and streamline the testing workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor splits the benchmark setup into two separate jobs for better handling of individual configurations: one for Docker-based benchmarks and another for PHP-based benchmarks. The jobs now support testing with varying numbers of columns. In addition, the CSV generation process now includes better-riched logs for easier debugging.