Add required rule for a column
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simplifies the schema validation rules and updates the associated documentation for improved readability and comprehensibility. It removes verbosity from validation notes in full.yml, replacing them with a succinct explanation, and encourages referencing README.md for detailed description of validation rules. Necessary changes were made in relevant source codes and tests to reflect this improvement.
This commit simplifies the schema validation rules and updates the associated documentation for improved readability and comprehensibility. It removes verbosity from validation notes in full.yml, replacing them with a succinct explanation, and encourages referencing README.md for detailed description of validation rules. Necessary changes were made in relevant source codes and tests to reflect this improvement.
Pull Request Test Coverage Report for Build 8506517922Details
💛 - Coveralls |
Modified the referenced tool name in the documentation from 'JBZoo/Csv-Blueprint tool' to 'CSV Blueprint tool' across several files. Additionally, realigned some text and bullet points for better readability and consistency.
Modified the referenced tool name in the documentation from 'JBZoo/Csv-Blueprint tool' to 'CSV Blueprint tool' across several files. Additionally, realigned some text and bullet points for better readability and consistency.
Modified the referenced tool name in the documentation from 'JBZoo/Csv-Blueprint tool' to 'CSV Blueprint tool' across several files. Additionally, realigned some text and bullet points for better readability and consistency.
An optional column offset parameter is now added to the getRecords method in CsvFile. This allows fetching of specific columns directly, reducing redundancy. Additionally, the ValidatorCsv logic was updated to use the fetched column value for data validation, which enhances both performance and code readability. Relevant tests and README documentation have also been updated to reflect these changes.
The logic related to column validation has been improved for CSV files. Now, the method getCsvOffset in the Column class allows for a null offset instead of throwing a RuntimeException. In the CsvFile class, the method getColumnsMappedByHeader has been updated to handle validation errors better. Where necessary, new validation errors are added for unused schema columns. Finally, the tests and the README documentation have been updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.