Update validation for multiple CSV files. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 13, 2024 00:18
The "ValidateCsv" command has been updated to handle multiple CSV files from given paths, providing the ability to validate multiple files at once. Relevant error messages and logs have been updated to reflect this change. Additionally, helper methods have been added to the Utils class for improved path handling.
The code has been updated to validate multiple CSV files at once when provided with a batch of paths. This includes corresponding adjustments in reporting errors, displaying success messages, and handling paths using added methods in the Utils class. Updated test suites to comply with the changes.
The commit includes refactoring to support batch processing of multiple CSV files, improving error reporting readability, and ensuring success messages for each validated file are displayed. Related test suites were also updated to match these changes. Changes also made to handle filepaths more efficiently within the Utils class.
…from subdirectories.
Updated the error reporting in 'ValidateCsv' file to include the word 'Error' in red for clearer visibility. Also simplified the depth condition in the 'Utils' file and made the 'location' element more concise in 'ValidatorTest'. This makes the code cleaner, more readable and enhances the visibility of errors.
This commit refactors the error message output when validating CSVs to better signify invalid files. Additionally, the process of finding files has been improved with clear depth conditions and sorted file results. An overall update to test cases and documentation reflects these changes for consistency.
This commit adds a new task in the README's feature checklist to include validation support for files stored in an S3 bucket. This update indicates an intended expansion of the validation process to incorporate data stored in the cloud.
Pull Request Test Coverage Report for Build 8256620468Details
💛 - Coveralls |
added 4 commits
March 13, 2024 01:37
This commit updates the README file, indicating the completion of several tasks related to CSV file validation. The tasks include file discovery with regex filename pattern, validating all files in a folder, and checking multiple CSV files in one schema.
This update tweaks the file sorting process in Utils.php to use ksort instead of sortByName for more accurate results. Also, redundant code in the CommandsTest unit test has been eliminated and additional test cases for multiple CSV options have been added to ensure a comprehensive testing suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "ValidateCsv" command has been updated to handle multiple CSV files from given paths, providing the ability to validate multiple files at once. Relevant error messages and logs have been updated to reflect this change. Additionally, helper methods have been added to the Utils class for improved path handling.