Fix code smells in SonarQube #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PHP scripts (`build-preloader.php` and `random-csv.php`) used in Docker have been refactored to use new CSV tool classes instead of self-contained solutions. New `PreloadBuilder` and `RandomCsvGenerator` classes are introduced for better reusability and tests for these new classes have been added. Also, minor adjustments on SonarQube regex checks and the project readme were made.
Pull Request Test Coverage Report for Build 8662712446Details
💛 - Coveralls |
SmetDenis
changed the title
Renamed the variable `isCompiler` to `enableOpcacheCompiler` in the PreloadBuilder to enhance clarity and reflect its purpose more accurately. This change was applied in the build-preloader.php, PreloadBuilder.php, and PreloadBuilderTest.php files.
Pull Request Test Coverage Report for Build 8663146787Details
💛 - Coveralls |
Refactored test method name in PreloadBuilderTest for clarity. Added new test `testPreloaderWithCompiling` to cover more cases, primarily for PreloadBuilder with opcache compiler enabled. Check for specific function existence in compiled contents.
The refactoring of PreloadBuilder pivots from handling class lists to managing file lists, with its related functions and output messages updated accordingly. This revamp includes the removal of '/app/csv-blueprint.php' from the exclusions list. Tests have been adjusted as well to mirror these alternations, adding the check for 'vendor/autoload.php'.
This change refactors PreloadBuilder to handle file lists instead of classes, ensuring the files are unique. Additionally, it updates the excluded files to be more specific and includes both 'csv-blueprint' and 'csv-blueprint.php' in the project root directory.
SmetDenis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP scripts (
build-preloader.phpandrandom-csv.php) used in Docker have been refactored to use new CSV tool classes instead of self-contained solutions. NewPreloadBuilderandRandomCsvGeneratorclasses are introduced for better reusability and tests for these new classes have been added. Also, minor adjustments on SonarQube regex checks and the project readme were made.