Improve CSV schema validation with filename patterns #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces filename pattern validation to the CSV schema, which allows increased data consistency checks. It also extends the capability to include additional columns to the schema, providing a more flexible structure. Enhancements were also made to error handling, introducing a quick-stop feature to expedite error discovery.
Pull Request Test Coverage Report for Build 8271091436Details
💛 - Coveralls |
added 3 commits
March 14, 2024 00:17
Previously, the invalid CSV file steps in our workflows performed their tasks differently and continued on errors. Now, the mechanism has been streamlined, and errors will halt the execution. This change results in more accurate validation and error detection.
This update introduces the use of the Utils::cutPath function in the error reporting for filename pattern mismatch in CsvFile.php. The error message, now, only displays the relative file path instead of the absolute one. The changes help decrease verbosity and improve clarity in error messages raised during CSV file validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces filename pattern validation to the CSV schema, which allows increased data consistency checks. It also extends the capability to include additional columns to the schema, providing a more flexible structure. Enhancements were also made to error handling, introducing a quick-stop feature to expedite error discovery.