Fixes

JBZoo · Apr 11, 2022 · 21de31f · 21de31f
1 parent a54433e
commit 21de31f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/CliCommand.php b/src/CliCommand.php
@@ -183,8 +183,9 @@ protected function getOptFloat(string $optionName): float
      */
     protected function getOptString(string $optionName): string
     {
-        $value = (string)$this->getOpt($optionName);
-        return \trim($value) ?: '';
+        $value = trim((string)$this->getOpt($optionName));
+        $length = \strlen($value);
+        return $length > 0 ? $value : '';
     }
 
     /**

diff --git a/tests/Cli/CliOptionsTest.php b/tests/Cli/CliOptionsTest.php
@@ -112,7 +112,7 @@ public function testOptionRequiredAndDefault()
             "Bool"    => false,
             "Int"     => 0,
             "Float"   => 0,
-            "String"  => "0",
+            "String"  => '0',
             "Array"   => ['0']
         ], $output[$option]);