Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal PHP version is 7.4 #18

Merged
merged 8 commits into from
Jun 5, 2022
Merged

Minimal PHP version is 7.4 #18

merged 8 commits into from
Jun 5, 2022

Conversation

SmetDenis
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jun 5, 2022

Pull Request Test Coverage Report for Build 2443384245

  • 9 of 11 (81.82%) changed or added relevant lines in 2 files are covered.
  • 15 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-4.7%) to 67.134%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/CovCatcher.php 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/AbstractCodestyleTest.php 1 85.15%
src/CovCatcher.php 1 14.52%
src/AbstractCopyrightTest.php 2 92.77%
src/fake-index.php 3 0%
src/functions/aliases.php 8 89.71%
Totals Coverage Status
Change from base Build 1675010922: -4.7%
Covered Lines: 335
Relevant Lines: 499

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #18 (8a251ad) into master (729dff3) will increase coverage by 2.49%.
The diff coverage is 100.00%.

❗ Current head 8a251ad differs from pull request most recent head 906666b. Consider uploading reports for the commit 906666b to get more accurate results

@@             Coverage Diff              @@
##             master      #18      +/-   ##
============================================
+ Coverage     65.40%   67.90%   +2.49%     
  Complexity       89       89              
============================================
  Files            11       11              
  Lines           610      564      -46     
============================================
- Hits            399      383      -16     
+ Misses          211      181      -30     
Impacted Files Coverage Δ
src/AbstractComposerTest.php 100.00% <ø> (ø)
src/functions/aliases.php 90.34% <100.00%> (+8.02%) ⬆️
src/functions/tools.php 81.25% <0.00%> (-2.63%) ⬇️
src/CovCatcher.php 14.66% <0.00%> (-1.13%) ⬇️
src/fake-index.php 0.00% <0.00%> (ø)
src/functions/defines.php 0.00% <0.00%> (ø)
tests/fixtures/includes/cov-catcher.php 100.00% <0.00%> (ø)
tests/fixtures/includes/cov-catcher-exception.php 100.00% <0.00%> (ø)
src/AbstractCodestyleTest.php 86.60% <0.00%> (+3.13%) ⬆️
src/AbstractCopyrightTest.php 93.93% <0.00%> (+5.65%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729dff3...906666b. Read the comment docs.

@SmetDenis SmetDenis merged commit 70f238e into master Jun 5, 2022
@SmetDenis SmetDenis deleted the php-74 branch June 5, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants