-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmake option to not build OpenMP by default. #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks reasonable, though I have not tested it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Cheyenne with GNU.
FYI. I tried to build the model inside mpas-bundle without OpenMP using jedi-gnu modules. This does NOT solve the problem: the executable still can not do 30-km mesh forecast. For my case, it hangs at
When I build the same source code with the traditional way using intel+mpt, it can run the forecast with the same initial condition file. Related issues are documented at https://github.com/JCSDA-internal/mpas-bundle/issues/90. |
Is this ready to merge? |
I think so. |
@liujake, I started seeing this same hanging issue in some |
On Cheyenne, when submitting jobs (for example, #PBS -l select=6:ncpus=32:mpiprocs=32), OMP_NUM_THREADS will default to the value of ncpus (=32 in this example). Either add ompthreads=xx setting to PBS, or setenv OMP_NUM_THREADS xx in the script to specify desired threads. When mpas/mpas_jedi is compiled with OpenMP and the job is run with more than 1 OMP_NUM_THREADS, it hangs somewhere after `----- done checking limited-area settings -----` in log.atmosphere.0000.out. This PR changes the default behavior of cmake from Enable OpenMP to disabled.
On Cheyenne, when submitting jobs (for example, #PBS -l select=6:ncpus=32:mpiprocs=32), OMP_NUM_THREADS will default to the value of ncpus (=32 in this example). Either add ompthreads=xx setting to PBS, or setenv OMP_NUM_THREADS xx in the script to specify desired threads.
When mpas/mpas_jedi is compiled with OpenMP and the job is run with more than 1 OMP_NUM_THREADS, it hangs somewhere after
----- done checking limited-area settings -----
in log.atmosphere.0000.out.This PR changes the default behavior of cmake from Enable OpenMP to disabled.