Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eva Refactoring #109

Merged
merged 12 commits into from
Jun 21, 2023
Merged

Eva Refactoring #109

merged 12 commits into from
Jun 21, 2023

Conversation

asewnath
Copy link
Collaborator

Description

Refactoring eva for more clarity.

List of changes:

  • Decoupled eva base class from drivers. The eva base class and factory is reserved for runtime generation of data handlers. We plan to eventually add another abstractmethod to eva base so that data handlers generate their own default config for eva interactive (this means also removing config from the eva base constructor).
  • The main 'eva' method is moved to eva_driver.py
  • Drivers are turned into functions. Logger and timer are provided to the functions
  • setup.py and eva_tests are updated to reflect these changes
  • 'diagnostics' and 'data' are removed from all yaml files
  • updated files to not expect 'diagnostics' and 'data' keywords

Copy link
Collaborator

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing this!

src/eva/eva_driver.py Outdated Show resolved Hide resolved
@danholdaway danholdaway merged commit 5ed29be into develop Jun 21, 2023
4 checks passed
@danholdaway danholdaway deleted the feature/eva_refactoring branch June 21, 2023 19:23
@asewnath asewnath mentioned this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants