Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for new EVA convention #522

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Update for new EVA convention #522

merged 1 commit into from
Jul 6, 2023

Conversation

CoryMartin-NOAA
Copy link
Contributor

Addresses changes made in JCSDA-internal/eva#109

@CoryMartin-NOAA CoryMartin-NOAA self-assigned this Jul 5, 2023
@CoryMartin-NOAA CoryMartin-NOAA added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jul 5, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 5, 2023
ADCollard
ADCollard approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@ADCollard ADCollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot cleaner

@emcbot
Copy link

emcbot commented Jul 5, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Jul  5 20:18:44 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jul  5 21:27:49 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jul  5 21:43:09 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 49

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 5, 2023
AndrewEichmann-NOAA
AndrewEichmann-NOAA approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the soca ctests with g-w and they produced eva plots so looks good!

@CoryMartin-NOAA CoryMartin-NOAA merged commit a2caa70 into develop Jul 6, 2023
11 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the bugfix/eva branch July 6, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyhcliu emilyhcliu emilyhcliu approved these changes

@ADCollard ADCollard ADCollard approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA approved these changes

@guillaumevernieres guillaumevernieres Awaiting requested review from guillaumevernieres

Assignees

@CoryMartin-NOAA CoryMartin-NOAA

Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CoryMartin-NOAA @emcbot @emilyhcliu @ADCollard @AndrewEichmann-NOAA