Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ioda-converters YAML for [3D]-RTMA ADPUPA BUFR #1454

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

PraveenKumar-NOAA
Copy link
Contributor

@PraveenKumar-NOAA PraveenKumar-NOAA commented Feb 2, 2024

Description

This PR adds an ioda-converters YAML for the [3D]-RTMA ADPUPA BUFR data.

The following files are new/ modified:

testinput/bufr_ncep_rtma_adpupa.yaml
testinput/rtma.t00z.adpupa.tm00.bufr_d
testoutput/rtma.t00z.adpupa.tm00.nc
CMakeLists.txt

The ioda-validation test is performed and following results were obtained:

Final results:
errors: 0
warnings: 0

The validation of the output ioda obs is also performed in: #1451

Issue(s) addressed

Resolves #1450

Dependencies

None

Impact

None

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@PraveenKumar-NOAA PraveenKumar-NOAA added the OBS OBS processing, UFO label Feb 2, 2024
@PatNichols PatNichols added the NWS NOAA National Weather Service label Feb 2, 2024
Copy link

@MatthewMorris-NOAA MatthewMorris-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nicholasesposito
Copy link
Contributor

Looks great

@fcvdb
Copy link
Contributor

fcvdb commented Feb 5, 2024

@PraveenKumar-NOAA The Netcdf output file size is a little bit large (2.48Mb), is there a way you could subsample the input BUFR file to reduce the size of the output? Thanks.

@PraveenKumar-NOAA
Copy link
Contributor Author

@PraveenKumar-NOAA The Netcdf output file size is a little bit large (2.48Mb), is there a way you could subsample the input BUFR file to reduce the size of the output? Thanks.

@fcvdb I used only one subset for the BUFR file and which is less than 1 Mb. I am not sure if it can be reduced further. Similar is true for for prepBUFR PR.

@PraveenKumar-NOAA
Copy link
Contributor Author

@fcvdb @PatNichols I fixed the file sizes, thanks to @ADCollard.

Copy link
Contributor

@PatNichols PatNichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reducing the file sizes.

Copy link
Collaborator

@BenjaminRuston BenjaminRuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @PraveenKumar-NOAA for this very critical decoder

@BenjaminRuston
Copy link
Collaborator

thank you @PraveenKumar-NOAA I've run this on a file like this which would be obtained from either the NCAR RDA archive or the NOMADS server and it completed fine and produced a reasonable looking file:

gdas.adpupa.t00z.20220216.bufr

file: 20220215T21_PT6H_adpupa_nesdis_bufr.nc4
range(/MetaData/dataReceiptTime): [--, --]
range(/MetaData/dateTime): [2022-02-15 21:00:00, 2022-02-16 02:00:00]
range(/MetaData/latitude): [-90.0, 82.5]
range(/MetaData/longitude): [-170.7100067138672, 179.22000122070312]
range(/MetaData/stationElevation): [-22, 4508]
range(/MetaData/stationIdentification): [02527, ZVQEQCM]
range(/MetaData/stationWIGOSId): [, ]
range(/ObsValue/airTemperature): [185.85000610351562, 307.1499938964844]
range(/ObsValue/dewPointTemperature): [163.25, 300.1499938964844]
range(/ObsValue/pressure): [300, 109900]
range(/ObsValue/windDirection): [0, 360]
range(/ObsValue/windSpeed): [0.0, 156.0]
range(/QualityMarker/airTemperature): [14, 14]
range(/QualityMarker/dewPointTemperature): [14, 14]
range(/QualityMarker/pressure): [14, 14]
range(/QualityMarker/stationElevation): [1, 1]
range(/QualityMarker/windSpeed): [14, 14]

one thing I notice is the pressure variable is not in MetaData which has been standard practice with radiosonde . It is instead under the ObsValue

@gthompsnJCSDA and @CoryMartin-NOAA and @emilyhcliu we should discuss think we can move forward for now, but believe our current practice is to have pressure under MetaData as it is essentially the location information

@BenjaminRuston
Copy link
Collaborator

getting this plot for the above file for observation only:
image

@BenjaminRuston BenjaminRuston merged commit dd4f97c into develop Feb 8, 2024
6 checks passed
@BenjaminRuston BenjaminRuston deleted the feature/rtma_adpupa_bufr branch February 8, 2024 00:03
@gthompsnJCSDA
Copy link
Contributor

FYI. This is already merged but the ObsTeam needs to do a better job with validating the incoming data against the IODA-validate program. The dimension name RadiosondeReportLevelData is ad hoc and never before seen. I realize we have been lax with ioda-validate set to ignore warnings and errors, but it's up to our own team and reviewers to know that we cannot allow new entires to go against the conventions or else we have no point in the conventions.

Let's be sure to correct the dimension name and MetaData/pressure in place of ObsValue/pressure in a subsequent PR please.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NWS NOAA National Weather Service OBS OBS processing, UFO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example YAMLs for the [3D]-RTMA ADPUPA prepBUFR/ BUFR Data
7 participants