Merge feature/no_physics_dependencies_based_on_dev_emc into release-stable (aka "overwrite release-stable with climbfuji's branch") #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing with the GFDL FV3 201912 version
…rface value is not forced to be positive
Merge EMC dev/emc to GFDL dev/emc
…all that caused a reproducibility issue.
…all that caused a reproducibility issue.
Modify the halo extents of u and vt in the regional_boundary_update call
Merge dev/emc branch from upstream (NOAA-GFDL/GFDL_atmos_cubed_sphere)
…all that caused a reproducibility issue. (NOAA-GFDL#55) Co-authored-by: Chan-hoo.Jeon <chan-hoo.jeon@noaa.gov>
merge ufs-release/public-v2 -> dev/emc
…public-v2 Revert "merge ufs-release/public-v2 -> dev/emc"
Merge 'regional_boundary_update' from upstream
…d_sphere into dtc/hwrf-physics
* updating doxygen documentation as requested from EMC for UFS MRW release of version 1.1 * updated documentation for ufs v1.1 specifically: updated d2_bg_k2 description per Jeff Whitaker, and removed sections A.2, A.8, and A.9 from the documentation Parameters List. * Further updates to ufs documentation * removing version number form Doxyfile Co-authored-by: bensonr <6594772+bensonr@users.noreply.github.com>
…piler when DEBUG=Y
Add a positive-definite advection option
…d_sphere into dtc/hwrf-physics
…tmos_cubed_sphere into udhmhj.04 fix conflicts.
* Bringing over internal updates to nh_core and nh_utils which includes a revision to the semi-implicit solver to linearize vertical sound wave propagation about the hydrostatic state. * resolve inconsistent use of single and double precision in rayleigh damping. Address spacing change. * rename tau_w * Modify the rff calculation to be fully double precision. Fixed a mistake in the previous cherry-pick commit * fully implement the name change of tau_w to fast_tau_w_sec
… intrinsic functions instead of a loop nest in range_check_3d()
dev/emc: Release FV3 Solver Updates (cherry-pick)
…s_quilting_restart Write BCs restart files from fv_dyn_restart_output
Update to latest in order to merge hafs-rangeCheck3d into mainline.
Revert 2c8363e to allow compiler opt…
…tmos_cubed_sphere into feature/no_physics_dependencies_based_on_dev_emc_20230717
…ttps://github.com/jcsda/gfdl_atmos_cubed_sphere into HEAD 2. Resolve conflicts and make release-stable identical to feature/no_physics_dependencies_based_on_dev_emc
|
Coordinated merge for this is planned for Monday, July 1. Are there other qualified reviewers we could add? Anna is on PTO until Monday. |
shlyaeva
approved these changes
Jun 26, 2024
CoryMartin-NOAA
approved these changes
Jun 27, 2024
|
Despite looking like a big change of 96 files, the actual changes between dev/emc and this branch results in 24 changed files. I inspected and diff-ed these files individually, and note the following:
I did not compile and run any tests. The changes look right to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR merges
feature/no_physics_dependencies_based_on_dev_emcintorelease-stableand applies additional changes so thatrelease-stableis identical tofeature/no_physics_dependencies_based_on_dev_emc.Issue(s) addressed
This PR is required for updating JEDI to a later version of the FV3 dycore (branch dev/emc of https://github.com/noaa-gfdl/atmos_cubed_sphere with additional changes on top of it, added by @climbfuji to be able to build the branch without the CCPP framework and physics dependencies).
Dependencies
Associated PRs:
Impact
See required changes in fv3-jedi-linearmodel, fv3-jedi, jedi-bundle
Checklist
I have performed a self-review of my own codeI have made corresponding changes to the documentation