Update to use FMS 2023.04 #1043
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/mom6_fms_update_dom_20240509
…pdate_dom_20240509
shlyaeva
added
the
coordinate merge
shlyaeva
changed the title
|
I don't see any CI runs? |
|
I just made it non-draft a few minutes ago; we'll need to trigger CI. |
|
I temporarily patched a change to the CI manifest that should allow this to build. It has already gotten past the first configuration step so we should have the results soon. I've already reverted the change (since it was global) so additional pushes will fail quickly as before. |
travissluka
approved these changes
Jun 14, 2024
| @@ -47,10 +48,7 @@ include_directories( ${NETCDF_INCLUDE_DIRS} ) | |||
| # Model | |||
| # TODO update to allow switching between mom6solo (here) and UFS (external) | |||
There was a problem hiding this comment.
note to self, or anyone else that cares, this is fine for now but I'm assuming we're building MOM6 twice when soca is built as part of the ufs-bundle. No real harm, but wasteful. At some point special logic should be added to use a prebuilt mom6 lib if it exists.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All work done by @climbfuji and @travissluka, I'm just raking up PR points.
jedi-ci-bundle-branch=feature/no_gfdl_forks
jedi-ci-next=true
build-group=https://github.com/JCSDA-internal/fv3-jedi-linearmodel/pull/17
build-group=JCSDA/GFDL_atmos_cubed_sphere#6
build-group=https://github.com/JCSDA-internal/fv3-jedi/pull/812