Rename function MISC::remove_space() to MISC::utf8_trim()
#1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
以前変更した`MISC::ascii_trim()`[1]と同じく 関数名を変更して何を行うのか分かりやすくします。 [1]: commit 62abdbf
`utf8_trim()`は入力に半角スペース(U+0020)が含まれてないときは トリミングが実行されない挙動になっています。 この挙動が合っているかどうか検証を考えていますが 今のところはコメントとテストケースを追加して補足しておきます。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename function MISC::remove_space() to MISC::utf8_trim()
以前変更した
MISC::ascii_trim()[1]と同じく関数名を変更して何を行うのか分かりやすくします。[1]: commit 62abdbf
Add a test case MISC::utf8_trim()
utf8_trim()は入力に半角スペース(U+0020)が含まれてないときはトリミングが実行されない挙動になっています。この挙動が合っているかどうか検証を考えていますが今のところはコメントとテストケースを追加して補足しておきます。