Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename function MISC::remove_space() to MISC::utf8_trim() #1011

Merged
merged 2 commits into from Jul 3, 2022
Merged

Rename function MISC::remove_space() to MISC::utf8_trim() #1011

merged 2 commits into from Jul 3, 2022

Commits on Jul 3, 2022

  1. Rename function MISC::remove_space() to MISC::utf8_trim() 

    以前変更した`MISC::ascii_trim()`[1]と同じく
関数名を変更して何を行うのか分かりやすくします。

[1]: commit 62abdbf
    @ma8ma
    ma8ma committed Jul 3, 2022
    Copy the full SHA
    95ca1df View commit details
    Browse the repository at this point in the history

  2. Add a test case MISC::utf8_trim() 

    `utf8_trim()`は入力に半角スペース(U+0020)が含まれてないときは
トリミングが実行されない挙動になっています。
この挙動が合っているかどうか検証を考えていますが
今のところはコメントとテストケースを追加して補足しておきます。
    @ma8ma
    ma8ma committed Jul 3, 2022
    Copy the full SHA
    0da0f71 View commit details
    Browse the repository at this point in the history