Added the optional locale scope to the config/routes.rb file. Added a… #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… configuration variable called localize_routes that users can enable (disabled by default). This should prevent conflicts with any installations using a parent path that is not a locale (e.g. /blog/contact-us). Also updated the README to inform the users about the new option and incremented the version number.
| @@ -1,3 +1,3 @@ | |||
| module ContactUs | |||
| VERSION = "1.1.0" | |||
| VERSION = "1.1.1" | |||
There was a problem hiding this comment.
Freeze mutable objects assigned to constants.
|
I don't think the Travis failures are due to these changes. |
…ed strings and <1.9 style hash syntax
| @@ -23,6 +23,10 @@ module ContactUs | |||
| mattr_accessor :parent_mailer | |||
| @@parent_mailer = "ActionMailer::Base" | |||
|
|
|||
| # allows for a locale to appear in the path | |||
There was a problem hiding this comment.
Trailing whitespace detected.
…ed strings and <1.9 style hash syntax
…ed strings and <1.9 style hash syntax
|
@briri awesome I've made some updates to fix the broken build. Could you please update to the latest master to get the fixes, you can remove the version bump that I'll handle, and cleanup the extra/trailing whitespace warnings. Thank you. |
|
All set JDutil. I rebased and cleaned up the remaining houndci warnings. I also removed the version number change I had made. Thanks! |
|
Thanks @briri I've release version 1.2.0 with this included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… configuration variable called localize_routes that users can enable (disabled by default). This should prevent conflicts with any installations using a parent path that is not a locale (e.g. /blog/contact-us). Also updated the README to inform the users about the new option and incremented the version number.