Issue #236 - Handle Ctrl-C when Question#echo = false (raw_no_echo_mode) #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to io/console at commit at 24, September, 2019 * ruby/io-console@7cba765 Released in Ruby 2.7.0, released at 25, December, 2019 * https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/ Documented at 17, February, 2020 * ruby/io-console@82b630c Documented in Ruby 2.7.1, released at 31, March, 2020 * https://ruby-doc.org/stdlib-2.7.1/libdoc/io/console/rdoc/IO.html#method-i-getch * https://www.ruby-lang.org/en/news/2020/03/31/ruby-2-7-1-released/
abinoam
changed the title
abinoam
added a commit
that referenced
this pull request
Apr 27, 2023
Ruby 2.7 is tagged End of Life (not even security maintanence) since this month. We (Highline) traditionally try to maintain compatibility with old rubies. But rubies bellow 2.7.1 lack "io/console" or they have incompatibilities. (as discussed in PR #259) So, this EOL of 2.7 signal to us that is time for us to move on. People relying on old versions of Highline will probably face no problem with it. But we will be free to start removing old code that is necessary only for retrocompatibility in newer versions.
Merged
abinoam
added a commit
that referenced
this pull request
Apr 27, 2023
Ruby 2.7 is tagged End of Life (not even security maintanence) since this month. We (Highline) traditionally try to maintain compatibility with old rubies. But rubies bellow 2.7.1 lack "io/console" or they have incompatibilities. (as discussed in PR #259) So, this EOL of 2.7 signal to us that is time for us to move on. People relying on old versions of Highline will probably face no problem with it. But we will be free to start removing old code that is necessary only for retrocompatibility in newer versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #236
Hi @Fahhetah,
I've set the author's commit to your e-mail to honor your suggestion.
But I've changed
exit 130toraise Interruptso it stays in line with Ruby standard behavior when receiving ctrl-C.I'll not merge it yet as I'm investigating a little further if I could have a better more complete approach.
Because treating all ctrl codes one by one seems not a good way for the long run.
cc: @Faheetah @Thalagyrt @aspyct
Of note, this commit message:
Handle interrupts directly at io/console was possible with the introduction of
introption togetch.Added to io/console at commit at 24, September, 2019
Released in Ruby 2.7.0, released at 25, December, 2019
Documented at 17, February, 2020
Documented in Ruby 2.7.1, released at 31, March, 2020
We should review all the code for other instances of handling control inputs like getch when echo is not false.
And, we will probably have to think about deprecating rubies older than 2.7 because they will have a different behavior. (Although the tests are passing because we use a mock with StringIO objects, not the actual consoles.