Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #236 - Handle Ctrl-C when Question#echo = false (raw_no_echo_mode) #259

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Issue #236 - Handle Ctrl-C when Question#echo = false (raw_no_echo_mode) #259

merged 4 commits into from
Jan 6, 2023

Commits on Jan 4, 2023

  1. Handle Ctrl-C when Question#echo = false (raw_no_echo_mode)

    @Faheetah @abinoam
    Faheetah authored and abinoam committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    e0e96cb View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Handle interrupts directly at io/console 

    Added to io/console at commit at 24, September, 2019
* ruby/io-console@7cba765

Released in Ruby 2.7.0, released at 25, December, 2019
* https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/

Documented at 17, February, 2020
* ruby/io-console@82b630c

Documented in Ruby 2.7.1, released at 31, March, 2020
* https://ruby-doc.org/stdlib-2.7.1/libdoc/io/console/rdoc/IO.html#method-i-getch
* https://www.ruby-lang.org/en/news/2020/03/31/ruby-2-7-1-released/
    @abinoam
    abinoam committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    aea8747 View commit details
    Browse the repository at this point in the history

  2. Update IOConsoleCompatible#getch to io/console signature

    @abinoam
    abinoam committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    3896a84 View commit details
    Browse the repository at this point in the history

  3. Add test for raise interrupt with ctrl-c

    @abinoam
    abinoam committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    75010bc View commit details
    Browse the repository at this point in the history