Skip to content

Commit

Permalink
Revert "scrub instance variables from test cases on teardown"
Browse files Browse the repository at this point in the history
This reverts commit b5cf2b4.
  • Loading branch information
jamis committed Jan 19, 2011
1 parent cd0ecff commit c545331
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 41 deletions.
2 changes: 0 additions & 2 deletions activesupport/lib/active_support/test_case.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
require 'active_support/testing/assertions'
require 'active_support/testing/deprecation'
require 'active_support/testing/declarative'
require 'active_support/testing/garbage_collection'

begin
gem 'mocha', ">= 0.9.7"
Expand Down Expand Up @@ -37,6 +36,5 @@ class TestCase < ::Test::Unit::TestCase
include ActiveSupport::Testing::Assertions
include ActiveSupport::Testing::Deprecation
extend ActiveSupport::Testing::Declarative
include ActiveSupport::Testing::GarbageCollection
end
end
19 changes: 0 additions & 19 deletions activesupport/lib/active_support/testing/garbage_collection.rb

This file was deleted.

18 changes: 0 additions & 18 deletions activesupport/test/test_case_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -74,23 +74,5 @@ def test_true; assert true end

assert_match %r{oh noes}, exception.message
end

def test_teardown_should_scrub_instance_variables
tc = Class.new(TestCase) do
def test_true; @alpha = "a"; assert_equal "a", @alpha; end
end

test_name = 'test_true'
fr = FakeRunner.new

test = tc.new test_name
test.run(fr) {}

passed_var = IS_MINITEST ? :@passed : :@test_passed
ivars = test.instance_variables.map(&:to_sym)

assert ivars.include?(passed_var), "#{passed_var} should not have been scrubbed"
assert !ivars.include?(:@alpha), "@alpha should have been scrubbed"
end
end
end
4 changes: 2 additions & 2 deletions activesupport/test/test_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class SetupAndTeardownTest < ActiveSupport::TestCase
def test_inherited_setup_callbacks
assert_equal [:reset_callback_record, :foo], self.class.setup_callback_chain.map(&:method)
assert_equal [:foo], @called_back
assert_equal [:scrub_leftover_instance_variables, :foo, :sentinel, :foo], self.class.teardown_callback_chain.map(&:method)
assert_equal [:foo, :sentinel, :foo], self.class.teardown_callback_chain.map(&:method)
end

def setup
Expand Down Expand Up @@ -174,7 +174,7 @@ class SubclassSetupAndTeardownTest < SetupAndTeardownTest
def test_inherited_setup_callbacks
assert_equal [:reset_callback_record, :foo, :bar], self.class.setup_callback_chain.map(&:method)
assert_equal [:foo, :bar], @called_back
assert_equal [:scrub_leftover_instance_variables, :foo, :sentinel, :foo, :bar], self.class.teardown_callback_chain.map(&:method)
assert_equal [:foo, :sentinel, :foo, :bar], self.class.teardown_callback_chain.map(&:method)
end

protected
Expand Down

0 comments on commit c545331

Please sign in to comment.