Add Accordion styles based on TitledPane style

[dukke]

Add Accordion styles based on TitledPane style

[MairwunNx]

Good issue, i can you help with it? Or only review your changes? :)

[dukke]

Sure thing.

Would you consider submitting PR. Do you want a few pointers on how to do it?

[MairwunNx]

@dukke I do not know how to do PR. Yes :)

[dukke]

@MairwunNx Sent you an email with some instructions. Cheers 👍

[MairwunNx]

@dukke Thanks bro! I see you instructions, if i do changes with accordion, i make pull request .)))

[MairwunNx]

Ahaha, TitledPane style == Accordion style, bro, accordion already done :DD

But, one minus, bottom border real bad, i think you can it fix easy, as i'm :D

[MairwunNx]

I think, you need just fix bottom border and close it issue, also thanks for PR instructions on future :)
If i want to change colors \ components - i create PR. 👍

[dukke]

Yeah I was kind of thinking it shouldn’t take much to have the accordion now. Thanks for letting me know that we just need to fix the border. I’ll try to do that today. Cheers

On Sun, 6 Jan 2019 at 08:53, Pavel Erokhin ***@***.***> wrote: I think, you need just fix bottom border and close it issue, also thanks for PR instructions on future :) If i want to change colors \ components - i create PR. 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AClQH4sZZJuqnxgVgK54aQcysY8zN9kZks5vAbmNgaJpZM4ZmEjJ> .

-- Pedro Duque Vieira - https://www.pixelduke.com

[MairwunNx]

@dukke no problem :) 👍

[MairwunNx]

@dukke Hi! How are you? Have you fixed border? :D

[dukke]

Good @MairwunNx , thanks!

Sorry too much work (on my paid job) 😞

Will try to add today.

[dukke]

@MairwunNx Sorry for the delay in fixing this issue. These days have been though, work wise.
I'll push a fix tomorrow for sure.

Thanks.

[MairwunNx]

@dukke Good, no problem :)) Goodluck with fixing bottom border of accordion 👍

[dukke]

Hi Pavel,

Worked a bit more on it today but I still haven't figured out why the last Titled Pane is being cut at the bottom...

[MairwunNx]

@dukke hi, i think i know what caused bottom not correct border, i need style, you already commit changes with pane?

[dukke]

The Titled Pane was already commited a few weeks ago.

I've fixed it. Only want to fix one more detail that has appeared: "the disabled border of the content of TitledPane isn't being the same as the border color of the Titled Pane header.
Hopefully I'll still have time today to make this small fix.

[MairwunNx]

You can see my changes, scroll up, and see as i make it :), maybe it help you.

[dukke]

This has been fixed and pushed. 👍

[MairwunNx]

Good Job @dukke ! 👍

What next tasks?

[dukke]

Thanks @MairwunNx !

I haven't really look into that but there are a few things I'd like to do:

• TreeTableView styles
• SplitPane?
• Dialogs?
• Accent color constants for easily changing to a nice accent color

[MairwunNx]

@dukke Hi! Thanks for // todo, i try make what i can realize, i also try to realize dialogs with supporting dark and light theme, and others your controls. 👍