Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set background colors for layout panes (BorderPane, etc) according to Style value. Also set them for Toolbar, ScrollPane, controls, etc #39

Closed
MairwunNx opened this issue Jan 30, 2019 · 5 comments

Comments

@MairwunNx
Copy link
Contributor

Dark theme:

image

After adding background style property:

image

image

I think it needed to do automatically, right? Because, new people who want to use your lib and themes, want what all controls be themed, right? Then need it do automatically, it no hard, just add background prop to it elements. just then theme applied to all controls needed, i think you understand me :)

additional ui elements needed to automatically background color: [ "Pane", "Anchor Pane", "Scroll Pane", "Scroll Pane Empty", "ToolBar"]

@dukke
Copy link
Member

dukke commented Jan 31, 2019

Yeah maybe we need to add default background values to Pane, Anchor Pane, etc, like you say.

@MairwunNx
Copy link
Contributor Author

@dukke OK ,if you think what I think right, than I try realize it in pull request :) or you can it make self

@MairwunNx
Copy link
Contributor Author

resolved in #42 , please @dukke review my changes, i already it done. :)

@dukke dukke changed the title Default theme based colors for panel, anchor panel. Fix background colors for layout panes (BorderPane, etc), Toolbar, ScrollPane, controls, etc May 12, 2019
@dukke
Copy link
Member

dukke commented May 12, 2019

I've changed the title of this issue.
There's a deeper problem with background colors not just for layout panes, scrollpane and toolbar.

Changing the default layout panes background colors will also change the background for other controls since some of them make use of these layout panes, so after changing the default layout panes background colors some controls backgrounds need to be corrected.

dukke added a commit that referenced this issue May 13, 2019
dukke added a commit that referenced this issue May 18, 2019
dukke added a commit that referenced this issue May 18, 2019
dukke added a commit that referenced this issue May 26, 2019
dukke added a commit that referenced this issue May 26, 2019
…e background colors of layout panes, menus, and such (issue #39)
@dukke dukke changed the title Fix background colors for layout panes (BorderPane, etc), Toolbar, ScrollPane, controls, etc Set background colors for layout panes (BorderPane, etc) according to Style value. Also set them for Toolbar, ScrollPane, controls, etc Jun 8, 2019
@dukke
Copy link
Member

dukke commented Jun 8, 2019

Fixed.

@dukke dukke closed this as completed Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants