Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuItem accelerator text is unconventional on macOS #141

Closed
Nibby opened this issue Jul 31, 2020 · 2 comments
Closed

MenuItem accelerator text is unconventional on macOS #141

Nibby opened this issue Jul 31, 2020 · 2 comments
Milestone

Comments

@Nibby
Copy link

Nibby commented Jul 31, 2020

Only tested on macOS. The menu item accelerator text has an extra plus character. It seems to be hard-coded in AWT. This is not coherent with the shortcut key style used natively.

For example, this menu item has a shortcut key of Command + Shift + N, but it is rendered as
Screen Shot 2020-07-31 at 1 48 39 PM

Which, for the less technical folks, may be misunderstood as Command + Plus + Shift + N.

DevCharly added a commit that referenced this issue Jul 31, 2020
…made modifier key order conform with macOS standard (issue #141)
@DevCharly
Copy link
Collaborator

Thx 👍

Fixed in master branch.

The order of the option keys was also wrong on macOS (not the same as in native macOS apps).
On native macOS the Control key is always first and the Command key the last option key.
For right-to-left orientation, the whole accelerator is now reversed on macOS (as in Aqua LaF).

@DevCharly DevCharly added this to the 0.39 milestone Jul 31, 2020
@Nibby
Copy link
Author

Nibby commented Aug 1, 2020

Thanks for your prompt responses as always.

@Nibby Nibby closed this as completed Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants