Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: JBRWindowTopBorder Color consistent and immersive #254

Closed
rememberber opened this issue Feb 5, 2021 · 3 comments
Closed

Request: JBRWindowTopBorder Color consistent and immersive #254

rememberber opened this issue Feb 5, 2021 · 3 comments
Milestone

Comments

@rememberber
Copy link

To make FlatLaf looks consistent and immersive,like IntelliJ IDEA.
If possible, I would like to request changing the default color in JBRWindowTopBorder or adding an change option.

Thanks a lot!

image

image

@DevCharly
Copy link
Collaborator

Thanks for request.
At the moment I'm undecided whether this should be the default.
Especially when not using the JetBrains Runtime, all-gray dialogs are hard to recognize
because they do not have drop shadow borders.
This will change soon when FlatLaf supports custom window decorations
with native Windows 10 drop shadows on all JREs. (I'm working on this)

If you want have this in your app now, do following:

Create a file FlatLaf.properties somewhere in the resources of your app (e.g. in package com.myapp.resources) with following content:

MenuBar.background = @background

Then tell FlatLaf in which package it can find the properties file with:

FlatLaf.registerCustomDefaultsSource( "com.myapp.resources" );

Note: This must be done before setting the Laf!

See https://www.formdev.com/flatlaf/how-to-customize/#application_properties

@rememberber
Copy link
Author

Thanks,got it!

DevCharly added a commit that referenced this issue Mar 14, 2021
@DevCharly
Copy link
Collaborator

@rememberber in FlatLaf 1.1 you can enable unified background with:

UIManager.put( "TitlePane.unifiedBackground", true );

image

See PR #268

@DevCharly DevCharly added this to the 1.1 milestone Mar 21, 2021
DevCharly added a commit that referenced this issue Apr 6, 2021
…ied backgrounds in cases were background is not filled by custom window/rootpane components (issue #254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants