Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSpinner - Left border issue #382

Closed
mlaggner opened this issue Sep 8, 2021 · 5 comments
Closed

JSpinner - Left border issue #382

mlaggner opened this issue Sep 8, 2021 · 5 comments
Milestone

Comments

@mlaggner
Copy link

mlaggner commented Sep 8, 2021

I've noticed a small glitch in the left border of the JSpinner if you have rounded corners:

image

looks like this could be a regression from 3e14f28

I've done no direct modifications to the JSpinner LaF (everything done with the .property files and all values for the spinner are the same as in the FlatLaf repo), so I guess this is an issue from FlatLaf

@DevCharly
Copy link
Collaborator

Looks like the embedded text field is opaque.

For me it works even with round border:

image

Do you use a custom editor in the spinner?

You could use FlatLaf UI Inspector to check it:

image

@mlaggner
Copy link
Author

mlaggner commented Sep 9, 2021

Thanks for the hint. Looks like this happens when a SpinnerNumberModel is set:

setModel(new SpinnerNumberModel(calendar.get(Calendar.YEAR), 0, calendar.getMaximum(Calendar.YEAR), 1));

image

If i remove the SpinnerNumberModel, everything is fine (see the border in the field below FSK)

@DevCharly
Copy link
Collaborator

Many thanks, I can reproduce it. It is a bug in FlatLaf...

DevCharly added a commit that referenced this issue Sep 13, 2021
…egression since FlatLaf 1.4)

ComboBox (editable): fixed wrong border of internal text field under special circumstances
@DevCharly
Copy link
Collaborator

Fixed in main branch.

@DevCharly DevCharly added this to the 1.6 milestone Sep 13, 2021
@mlaggner
Copy link
Author

thanks, works as expected!

DevCharly added a commit that referenced this issue Sep 22, 2021
…f round edges are enabled (similar to issue #382; regression since fixing #330 in FlatLaf 1.4)
DevCharly added a commit that referenced this issue Nov 11, 2021
…f round edges are enabled (similar to issue #382; regression since fixing #330 in FlatLaf 1.4)

(cherry picked from commit 02f3239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants