Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: [Scenario editor] "Many random towns" does not check for duplicate town names #583

Closed
wpi3 opened this issue Aug 1, 2023 · 2 comments
Closed

[Bug]: [Scenario editor] "Many random towns" does not check for duplicate town names #583

wpi3 opened this issue Aug 1, 2023 · 2 comments

Comments

@wpi3
Copy link

wpi3 commented Aug 1, 2023

Version of OpenTTD

0.54.4

Expected result

An error message should appear when there are insufficient/identical town names, similar to the other generate town buttons.

Actual result

Towns with duplicate town names are generated.

Steps to reproduce

  1. Open scenario editor
  2. Click "many random towns" in the town generation menu (do so for multiple times if the GRF supplies large amount of town names)
  3. Save the scenario and play it. Open the town list and sort by name. There should be town names that are duplicates of each other.
@JGRennison
Copy link
Owner

I've forwarded this upstream as OpenTTD/OpenTTD#11164

JGRennison added a commit that referenced this issue Aug 1, 2023
@JGRennison
Fix duplicate town names when using the many random towns function
665d6bf 
See: #583
@JGRennison
Copy link
Owner

Fixed in the most recent release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JGRennison @wpi3