Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Scenario editor: Many random towns function creates towns with duplicate names #11164

Closed
JGRennison opened this issue Aug 1, 2023 · 0 comments · Fixed by #11165
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

master

Expected result

All town names are unique

Actual result

Repeated use of the many random towns function in the scenario editor may create towns with duplicate names.

This is particularly the case when using poorly implemented town name generators, such as the French one.

GenerateTowns only checks the set of towns being added are unique with respect to each other, not with towns already on the map.

Steps to reproduce

Repeatedly use the many random towns function in the scenario editor

Villes de France.scn.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
2 participants