Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove KtLintIdea Plugin #726

Merged
merged 1 commit into from
Dec 1, 2023
Merged

remove KtLintIdea Plugin #726

merged 1 commit into from
Dec 1, 2023

Conversation

wakingrufus
Copy link
Collaborator

@wakingrufus wakingrufus commented Nov 30, 2023

This plugin is no longer needed as ktlint configuration is driven by .editorconfig now, which idea will respect out of the box

The plugin was already removed in 12.0.0, but we need to remove the declaration of the plugin in the build scripts to pass validation

@wakingrufus wakingrufus changed the title remove KtLintIdea Plugin. remove KtLintIdea Plugin Nov 30, 2023
This plugin is no longer needed as ktlint configuration is driven by .editorconfig now, which idea will respect out of the box
@JLLeitschuh JLLeitschuh merged commit cbd6150 into main Dec 1, 2023
16 of 17 checks passed
@JLLeitschuh JLLeitschuh deleted the remove-idea-plugin branch December 1, 2023 14:04
@Spikhalskiy
Copy link

Spikhalskiy commented Dec 4, 2023

This section of Readme should probably be deleted as a part of this change: https://github.com/JLLeitschuh/ktlint-gradle#intellij-idea-only-plugin

rami2076 added a commit to rami2076/kotlin-on-spring-boot that referenced this pull request Jan 12, 2024
不要なプラグインとなったので削除する.
JLLeitschuh/ktlint-gradle#726
org.jlleitschuh.gradle.ktlint-idea
@rtsketo
Copy link

rtsketo commented Mar 1, 2024

Shouldn't the README.md be updated as well?

It says:

plugins {
  id("org.jlleitschuh.gradle.ktlint-idea") version "<current_version>"
}

Honest question, otherwise I would have created a PR for this.

@JLLeitschuh
Copy link
Owner

Yes, please do feel free to create a PR to update the README 😄

dinomite added a commit to dinomite/ktlint-gradle that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants