Skip to content

Commit

Permalink
comment inconsistent methods
Browse files Browse the repository at this point in the history
  • Loading branch information
bobjacobsen committed Apr 8, 2018
1 parent 2068d9a commit 6938e1f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions java/src/jmri/jmrit/audio/AbstractAudioSource.java
Original file line number Diff line number Diff line change
Expand Up @@ -832,6 +832,10 @@ protected int getFading() {
return this.fading;
}

// note that this doesn't properly implement the
// contract in {@link NamedBean.toString()},
// which means things like tables and persistance
// might not behave properly.
@Override
public String toString() {
return "Pos: " + this.getPosition().toString()
Expand Down
4 changes: 4 additions & 0 deletions java/src/jmri/jmrit/logix/Portal.java
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,10 @@ public String getDescription() {
}

@Override
// note that this doesn't properly implement the
// contract in {@link NamedBean.toString()},
// which means things like tables and persistance
// might not behave properly.
public String toString() {
StringBuilder sb = new StringBuilder("Portal \"");
sb.append(getUserName());
Expand Down

0 comments on commit 6938e1f

Please sign in to comment.