WIP - Remove logging - Don't merge #13203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Please consider adding a release note in the help/en/releasenotes/current-draft-note.shtml file. |
|
It still fails the same way with this branch. If I disable the |
danielb987
commented
Jun 20, 2024
Comment on lines
+123
to
+128
| // Uncomment the line below and you will get the summary | ||
| // if (1==1) return; | ||
|
|
||
| InstanceManager.getDefault(ShutDownManager.class).shutdown(); | ||
|
|
||
| if (1==1) return; |
There was a problem hiding this comment.
@bobjacobsen
Note these lines. If you uncomment line 124, you will get the summary. So it seems to me that ShutDownManager.shutdown() is the culprit. But I don't know why. Maybe a mockup of the shutdown manager fails?
|
Closing this since it's not needed anymore. See #13204. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.