Fix SampleScriptTest #13204
Merged
Fix SampleScriptTest #13204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Please consider adding a release note in the help/en/releasenotes/current-draft-note.shtml file. |
bobjacobsen
approved these changes
Jun 21, 2024
icklesteve
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@icklesteve
@bobjacobsen
This seems to fix the
SampleScriptTestandTurnoutStatePersistence.py. At least the summary works now. The problem was thatSampleScriptTestcalledShutdownManager.shutdown()which in turn calledSystem.exit(status).One additional note:
DefaultShutDownManager.doShutdown(int status, boolean exit)has a Javadoc that's wrong. It says that it returns false if user aborts, but the method is void so it doesn't return any value. I haven't changed this since I'm not exactly sure how the Javadoc should be instead.Also, there is several
@SuppressFBWarnings()about DM_EXIT. The one fordoShutdown()is probably needed but the others can probably be removed.