Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better annotations and javadoc for DefaultShutDownManager #13205

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Better annotations and javadoc for DefaultShutDownManager #13205

merged 1 commit into from
Jun 22, 2024

Conversation

bobjacobsen
Copy link
Member

See PR #13204 for diagnosis

@mergeable Mergeable
Copy link

mergeable bot commented Jun 21, 2024

Thanks for the PR. Please consider adding a release note in the help/en/releasenotes/current-draft-note.shtml file.

@mergeable mergeable bot added the New PR Newly created PR that is less than 1 day old label Jun 21, 2024
danielb987
danielb987 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@danielb987 danielb987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@danielb987 danielb987 added this to the 5.9.1 milestone Jun 21, 2024
@danielb987 danielb987 removed the New PR Newly created PR that is less than 1 day old label Jun 22, 2024
@danielb987 danielb987 merged commit bdd62b7 into JMRI:master Jun 22, 2024
14 checks passed
@bobjacobsen bobjacobsen deleted the shutdown-javadoc branch July 13, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielb987 danielb987 danielb987 approved these changes

Assignees

@bobjacobsen bobjacobsen

Labels
None yet
Projects
None yet
Milestone
5.9.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bobjacobsen @danielb987