Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBUS Event Table Update #5653

Merged
merged 4 commits into from
Aug 18, 2018
Merged

Conversation

icklesteve
Copy link
Member

@icklesteve icklesteve commented Aug 16, 2018

General improvements to MERG CBUS Event Table

Sort row order by column.
Hide / Show Columns.

Send event on button.
Send event off button.
Send event Toggle button.
Send event status request button.
Event session counters,off, on + total.
Time date of event last heard on network.
Delete row from table button with dialogue box confirm, checkbox to disable confirmation rest of session.
Improved save to csv, added default filename with extension, dialogue confirm overwrite existing filename
Improved print view
Updated Event Table Documentation
Updated CBUS bundle

Addded Short Message lookup routine for general CBUS frames isShort

@bobjacobsen
Copy link
Member

CI encountered two JavaDoc errors:

/home/travis/build/JMRI/JMRI/java/src/jmri/jmrix/can/cbus/swing/eventtable/CbusEventTableDataModel.java:512: error: @param name not found
[ERROR]      * @param int row
[ERROR]               ^
[ERROR] 

/home/travis/build/JMRI/JMRI/java/src/jmri/jmrix/can/cbus/swing/eventtable/CbusEventTableDataModel.java:513: error: @param name not found
[ERROR]      * @param int OfforOn 1 is on, 0 is off, 2 is either
[ERROR]               ^

@icklesteve icklesteve changed the title CBUS Event Table Update WIP CBUS Event Table Update Aug 18, 2018
@icklesteve
Copy link
Member Author

[ERROR] Errors:
[ERROR] LayoutEditorToolsTest.testSetSignalHeadOnPanelAtXYDoubleAndRemove:230 » TimeoutExpired

@icklesteve icklesteve changed the title WIP CBUS Event Table Update CBUS Event Table Update Aug 18, 2018
@bobjacobsen bobjacobsen added this to the 4.13.3 milestone Aug 18, 2018
@bobjacobsen bobjacobsen merged commit d74cc23 into JMRI:master Aug 18, 2018
@icklesteve
Copy link
Member Author

Multiple Javadoc warnings, will submit further update in next 24hrs

@bobjacobsen
Copy link
Member

@icklesteve Thanks!

@bobjacobsen
Copy link
Member

@icklesteve There are also some style recommendations here: http://jmri.tagadab.com/jenkins/job/Development/job/SpotBugs/1882/findbugsResult/new/

@icklesteve
Copy link
Member Author

Thanks @bobjacobsen , hadn't found the Spotbugs pages before, oops!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants