New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBUS Event Table Update #5653

Merged
merged 4 commits into from Aug 18, 2018

Conversation

Projects
None yet
2 participants
@icklesteve
Contributor

icklesteve commented Aug 16, 2018

General improvements to MERG CBUS Event Table

Sort row order by column.
Hide / Show Columns.

Send event on button.
Send event off button.
Send event Toggle button.
Send event status request button.
Event session counters,off, on + total.
Time date of event last heard on network.
Delete row from table button with dialogue box confirm, checkbox to disable confirmation rest of session.
Improved save to csv, added default filename with extension, dialogue confirm overwrite existing filename
Improved print view
Updated Event Table Documentation
Updated CBUS bundle

Addded Short Message lookup routine for general CBUS frames isShort

@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Aug 18, 2018

Member

CI encountered two JavaDoc errors:

/home/travis/build/JMRI/JMRI/java/src/jmri/jmrix/can/cbus/swing/eventtable/CbusEventTableDataModel.java:512: error: @param name not found
[ERROR]      * @param int row
[ERROR]               ^
[ERROR] 

/home/travis/build/JMRI/JMRI/java/src/jmri/jmrix/can/cbus/swing/eventtable/CbusEventTableDataModel.java:513: error: @param name not found
[ERROR]      * @param int OfforOn 1 is on, 0 is off, 2 is either
[ERROR]               ^
Member

bobjacobsen commented Aug 18, 2018

CI encountered two JavaDoc errors:

/home/travis/build/JMRI/JMRI/java/src/jmri/jmrix/can/cbus/swing/eventtable/CbusEventTableDataModel.java:512: error: @param name not found
[ERROR]      * @param int row
[ERROR]               ^
[ERROR] 

/home/travis/build/JMRI/JMRI/java/src/jmri/jmrix/can/cbus/swing/eventtable/CbusEventTableDataModel.java:513: error: @param name not found
[ERROR]      * @param int OfforOn 1 is on, 0 is off, 2 is either
[ERROR]               ^

@icklesteve icklesteve changed the title from CBUS Event Table Update to WIP CBUS Event Table Update Aug 18, 2018

@icklesteve

This comment has been minimized.

Show comment
Hide comment
@icklesteve

icklesteve Aug 18, 2018

Contributor

[ERROR] Errors:
[ERROR] LayoutEditorToolsTest.testSetSignalHeadOnPanelAtXYDoubleAndRemove:230 » TimeoutExpired

Contributor

icklesteve commented Aug 18, 2018

[ERROR] Errors:
[ERROR] LayoutEditorToolsTest.testSetSignalHeadOnPanelAtXYDoubleAndRemove:230 » TimeoutExpired

@icklesteve icklesteve changed the title from WIP CBUS Event Table Update to CBUS Event Table Update Aug 18, 2018

@bobjacobsen bobjacobsen added this to the 4.13.3 milestone Aug 18, 2018

@bobjacobsen bobjacobsen merged commit d74cc23 into JMRI:master Aug 18, 2018

4 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 42.728%
Details
@icklesteve

This comment has been minimized.

Show comment
Hide comment
@icklesteve

icklesteve Aug 18, 2018

Contributor

Multiple Javadoc warnings, will submit further update in next 24hrs

Contributor

icklesteve commented Aug 18, 2018

Multiple Javadoc warnings, will submit further update in next 24hrs

@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen
Member

bobjacobsen commented Aug 18, 2018

@icklesteve Thanks!

@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen
Member

bobjacobsen commented Aug 18, 2018

@icklesteve

This comment has been minimized.

Show comment
Hide comment
@icklesteve

icklesteve Aug 19, 2018

Contributor

Thanks @bobjacobsen , hadn't found the Spotbugs pages before, oops!

Contributor

icklesteve commented Aug 19, 2018

Thanks @bobjacobsen , hadn't found the Spotbugs pages before, oops!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment