Added error handling when job fails permanently and failure callback …

…raises an exception

lib/delayed/backend/shared_spec.rb

@@ -538,6 +538,13 @@ def create_job(opts = {})
             expect(@job.payload_object).to receive(:failure)
             worker.reschedule(@job)
           end
+
+          it "handles error in hook" do
+            Delayed::Worker.destroy_failed_jobs = false
+            @job.payload_object.raise_error = true
+            expect{worker.reschedule(@job)}.not_to raise_error
+            expect(@job.failed_at).to_not be_nil
+          end
         end
 
         context "when the job's payload has no #failure hook" do

lib/delayed/worker.rb

@@ -233,8 +233,14 @@ def reschedule(job, time = nil)
 
     def failed(job)
       self.class.lifecycle.run_callbacks(:failure, self, job) do
-        job.hook(:failure)
-        self.class.destroy_failed_jobs ? job.destroy : job.fail!
+        begin
+          job.hook(:failure)
+        rescue Exception => error
+          say "Error when running failure callback: #{error}", Logger::ERROR
+          say error.backtrace.join("\n"), Logger::ERROR
+        ensure
+          self.class.destroy_failed_jobs ? job.destroy : job.fail!
+        end
       end
     end
 

spec/sample_jobs.rb

@@ -25,7 +25,9 @@ def perform; sleep 250; end
 end
 
 class OnPermanentFailureJob < SimpleJob
-  def failure; end
+  def initialize; @raise_error = false; end
+  def raise_error=(raise_error); @raise_error = raise_error; end
+  def failure; raise 'did not work' if @raise_error; end
   def max_attempts; 1; end
 end