Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards-incompatible API changes should increment version number #2

Closed
maxhawkins opened this issue Feb 1, 2013 · 1 comment
Closed

Comments

@maxhawkins
Copy link

Commits 0d4ee83 and e2d36a6 introduce backwards-incompatible API changes.

According to semver this means you should increment the version number to 2.0.0 or else make the changes backwards-compatible and increment to 1.1.0.

These changes caused problems for me because I specify ttt's version with '~> 1.0.0' in my gemfile. That means when I updated my bundle it automatically updated to the new, incompatible version and broke my build.

Please revert the backwards-incompatible changes or increment the version number to 2.0.0 to alert users of the change. Thanks!

JMongol added a commit that referenced this issue Feb 1, 2013
@JMongol
Copy link
Owner

JMongol commented Feb 1, 2013

You're right - sorry about that. I just pushed a fix for this. I'll push a new build of the gem up to rubygems as well when they come back online.

@JMongol JMongol closed this as completed Feb 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants