Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc improvements for Test-Package with Windows Sandbox #1

Open
wants to merge 1 commit into
base: addsSandboxTesting
Choose a base branch
from

Conversation

Thilas
Copy link

@Thilas Thilas commented Jun 21, 2023

On top of chocolatey-community#26, here a some changes I'd like to suggest:

  • change with parameter sets and parameters to make is clearer what the options are
  • change the way Test-Package determines the package name and version from a nupkg file (this could fail if the file is not named properly or if the package name ends with numbers)
  • use throw to ensure errors are properly raised & better error management overall
  • replace Test-Package.cmd by a Test-Package.ps1 in Sandbox to simplify how the test is setup (closer to Vagrant)
  • minimize Windows Sandbox windows as soon as possible to keep the focus on the current terminal

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant