(#4) Adds Windows Sandbox to Test-Package #26
Conversation
This adds a really messy addition to the Test-Package function, which allows users to test package install/uninstall with Windows Sandbox rather than Vagrant or Local testing. It is not in my regular style but attempts to match the existing function. I'm not fully successful in this.
|
@JPRuskin, what you've done here looks pretty good. What do you mean by "I'm not fully successful in this"? |
Ah, mostly just that my code-style doesn't fully match the rest of the module as it's currently written. I'll say that the way you currently need to invoke sandbox doesn't help this! |
There was a problem hiding this comment.
Instead of a classic review, here is a PR with a few changes I'd like to share regarding your work on Sandbox: JPRuskin#1
| Copy-Item -Path $Nu -Destination $SandboxTempFolder | ||
|
|
||
| try { | ||
| & WindowsSandbox "$SandboxTempFolder\ChocoTestingSandbox.wsb" |
There was a problem hiding this comment.
We should check for an existing windowssandbox process. If there is already one, then this will fail and we'll be waiting for the timeout to hit needlessly.
I would recommend the check happen early before we've done a bunch of setup.
| if ($Results.InstallExitCode -ne 0) { throw "choco install failed with $($Results.InstallExitCode)"} | ||
| } | ||
| if ($Uninstall) { | ||
| if ($Results.UninstallExitCode -ne 0) { throw "choco install failed with $($Results.UninstallExitCode)"} |
There was a problem hiding this comment.
Very true! I'll get that sorted
Description
This adds a really messy addition to the Test-Package function, which allows users to test package install/uninstall with Windows Sandbox rather than Vagrant or Local testing.
It is not in my regular style but attempts to match the existing function. I'm not fully successful in this.
Motivation / Context
There was a request to use Windows Sandbox, which is wonderfully performant, for package testing. This seemed like a great addition!
Fixes #4.