Fix: apply length check on type + scope + message (closes #35) (#42)

* Fix: apply length check on type + scope + message

* Test: update tests for new length check

* Feat: add validation for empty commit message

* Test: add empty commit message

* Fix: predefine might empty answer.scope

lib/questions.js

@@ -65,8 +65,15 @@ const questions = (config) => {
       type: 'input',
       name: 'description',
       message: 'Enter your commit message:',
-      validate: (input) => {
-        const warnings = ruleWarningMessages(input.trim(), config);
+      validate: (input, answers) => {
+        if (input.length === 0) {
+          return 'The commit message is not allowed to be empty';
+        }
+
+        const scope = answers.scope || '';
+        const type = combineTypeScope(answers.type, scope.trim());
+        const combinedInput = `${type} ${input.trim()}`;
+        const warnings = ruleWarningMessages(combinedInput, config);
 
         return warnings || true;
       },

test/questions.js

@@ -111,8 +111,9 @@ test('COMMIT | validate functions in questions', (t) => {
   const config = getConfig();
   const questionsList = questions(config);
 
-  t.is(questionsList[2].validate('input text'), true);
-  t.is(questionsList[2].validate('This message has over 72 characters. So this test will definitely fail. I can guarantee that I am telling the truth'), 'The commit message is not allowed to be longer as 72 character, but is 115 character long. Consider writing a body.\n');
+  t.is(questionsList[2].validate('', 'Fix: '), 'The commit message is not allowed to be empty');
+  t.is(questionsList[2].validate('input text', 'Fix: '), true);
+  t.is(questionsList[2].validate('This message has over 72 characters. So this test will definitely fail. I can guarantee that I am telling the truth', 'Fix: '), 'The commit message is not allowed to be longer as 72 character, but is 125 character long. Consider writing a body.\n');
 });
 
 test('COMMIT | when and default functions in questions', (t) => {