Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: apply length check on type + scope + message (closes #35) #42

Merged
merged 10 commits into from
Oct 1, 2017
Merged

Fix: apply length check on type + scope + message (closes #35) #42

merged 10 commits into from
Oct 1, 2017

Conversation

aichbauer
Copy link
Collaborator

No description provided.

JPeer264
JPeer264 approved these changes Sep 8, 2017
View reviewed changes
Copy link
Owner

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing what can happen is that the input is empty but everything else is long enough it would work.

Repository owner deleted a comment from coveralls Sep 8, 2017
@coveralls
Copy link

coveralls commented Sep 12, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling e832eb6 on fix/checkCompleteLength into d1a9958 on master.

Repository owner deleted a comment from coveralls Oct 1, 2017
Repository owner deleted a comment from coveralls Oct 1, 2017
Repository owner deleted a comment from coveralls Oct 1, 2017
@coveralls
Copy link

coveralls commented Oct 1, 2017 •
edited

Coverage Status

Changes Unknown when pulling 45e6d63 on fix/checkCompleteLength into ** on master**.

@JPeer264 JPeer264 merged commit 35c42c9 into master Oct 1, 2017
@JPeer264 JPeer264 deleted the fix/checkCompleteLength branch October 1, 2017 17:05
JPeer264 pushed a commit that referenced this pull request Oct 1, 2017
@aichbauer @JPeer264
Fix: apply length check on type + scope + message (closes #35) (#42)
f37923b 
* Fix: apply length check on type + scope + message

* Test: update tests for new length check

* Feat: add validation for empty commit message

* Test: add empty commit message

* Fix: predefine might empty answer.scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPeer264 JPeer264 JPeer264 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aichbauer @coveralls @JPeer264