New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: sgc --retry (closes #65) #69

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@JPeer264
Owner

JPeer264 commented Nov 3, 2018

@aichbauer any suggestions on how to test this?

@JPeer264 JPeer264 requested a review from aichbauer Nov 3, 2018

@coveralls

This comment has been minimized.

coveralls commented Nov 3, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling e895ec7 on feat/retry into b30c854 on master.

@coveralls

This comment has been minimized.

coveralls commented Nov 3, 2018

Coverage Status

Coverage decreased (-24.6%) to 75.35% when pulling 1a5d59e on feat/retry into b30c854 on master.

@aichbauer

This comment has been minimized.

Collaborator

aichbauer commented Nov 3, 2018

Maybe you could make functions that read/writes the retry files and you call it in the cli.js so you have it separated from the cli input and then you could test if this function works properly?

Why are you rewriting some functions with async/await and others not?

@JPeer264

This comment has been minimized.

Owner

JPeer264 commented Nov 3, 2018

Maybe you could make functions that read/writes the retry files and you call it in the cli.js so you have it separated from the cli input and then you could test if this function works properly?

Ya that would work.

Why are you rewriting some functions with async/await and others not?

Because top level await does not exist yet. And wrapping it into an own function would have been a little bit of an overhead. But ya maybe we should stick just either promises or async/await. Could rewrite it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment