-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: sgc --retry (closes #65) #69
Conversation
Maybe you could make functions that read/writes the retry files and you call it in the Why are you rewriting some functions with |
Ya that would work.
Because top level await does not exist yet. And wrapping it into an own function would have been a little bit of an overhead. But ya maybe we should stick just either promises or |
@aichbauer tests added 👍 |
I also did a little refactoring. Unfortunately it is in this PR, as it was too difficult to put it in another PR. |
I will take a look into it as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@aichbauer any suggestions on how to test this?