Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow --ignore-scripts to be disabled, if needed #102

Merged
merged 2 commits into from Jun 2, 2023

Conversation

mcous
Copy link
Member

@mcous mcous commented Jun 2, 2023

Overview

Taking a look back at closed issues in this repo, I've seen some external issues linked back that indicated folks have been running into issues with adding --ignore-scripts to all npm calls. In hindsight, setting it by default, rather quietly, probably needed a little more consideration.

But it's where we're at now, so let's make the most of it! This PR adds an ignore-scripts input to the action (and CLI and lib) that can be set to false, for users who rely on lifecycle scripts for publish and understand the security implications.

uses: JS-DevTools/npm-publish@v2
with:
  token: ${{ secrets.NPM_TOKEN }}
  ignore-scripts: false

@mcous
Copy link
Member Author

mcous commented Jun 2, 2023

Taking a coverage hit in the @actions/core wrapper, but that's the wrapper's job

@mcous mcous merged commit cb083ce into main Jun 2, 2023
15 of 25 checks passed
@mcous mcous deleted the no-ignore-scripts branch June 2, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant