Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from matrix to build stages #15

Closed
wants to merge 3 commits into from

Conversation

cotsog
Copy link

@cotsog cotsog commented Dec 13, 2018

No description provided.

@coveralls
Copy link

coveralls commented Dec 13, 2018

Pull Request Test Coverage Report for Build 136

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.536%

Totals Coverage Status
Change from base Build 134: 0.0%
Covered Lines: 283
Relevant Lines: 284

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 136

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.536%

Totals Coverage Status
Change from base Build 134: 0.0%
Covered Lines: 283
Relevant Lines: 284

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 136

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.536%

Totals Coverage Status
Change from base Build 134: 0.0%
Covered Lines: 283
Relevant Lines: 284

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 13, 2018

Pull Request Test Coverage Report for Build 138

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.536%

Totals Coverage Status
Change from base Build 134: 0.0%
Covered Lines: 283
Relevant Lines: 284

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 136

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.536%

Totals Coverage Status
Change from base Build 134: 0.0%
Covered Lines: 283
Relevant Lines: 284

💛 - Coveralls

@JamesMessinger
Copy link
Member

Any particular reason for this? As far as I can tell, it accomplishes the same task, but slower, since each stage runs sequentially

Needed to override `node_js` and `os` in the build stage definition
@cotsog
Copy link
Author

cotsog commented Dec 14, 2018

My bad for the first commit.

In the end you need to make sure to override the node_js and os keys in your Deploy stage.

See https://docs.travis-ci.com/user/build-stages/matrix-expansion/.

@JamesMessinger
Copy link
Member

It's unnecessary to set the node_js and os keys in the "Deploy" stage because they are automatically inherited from the build matrix.

See https://docs.travis-ci.com/user/build-stages/#build-stages-and-build-matrix-expansion

@cotsog
Copy link
Author

cotsog commented Dec 14, 2018

It seems my assumptions were wrong. I wrongfully thought that you would need to define the os and node_js keys in you deploy stage in order for the resulting job to be recognized as a different stage. However, I did some tests with and without the keys being defined and I could not reproduce your issue. I'm following up with you via e-mail. Thanks!

@cotsog cotsog closed this Dec 14, 2018
@cotsog cotsog deleted the patch-1 branch December 14, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants