Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and updates to the CI workflow #1123

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Conversation

bcoconni
Copy link
Member

This PR addresses a fix and a couple of updates to the CI workflow:

  • Remove the space between -- and parallel in the file .github/workflows/cpp-python-build.xml as it results in the failure of the tests run on the Windows/MSVC platform. For some reason, although this was a syntax error, it is only recently that this has prevented the CI workflow to run.
    run: ctest -- parallel $Env:NUMBER_OF_PROCESSORS --build-config RelWithDebInfo --output-on-failure
  • Fixes the capitalization of JSBSim in the .github/workflows/cpp-python-build.xml. It must be all lower cases now (most likely a change in setuptools ?)
    cp -R JSBSim-*/jsbsim/*.pyi ../../build/python/jsbsim/.
  • Update cibuildwheel to its latest revision i.e. 2.19
  • Drop the action crazy-max/ghaction-github-pages and use the GitHub pages workflow instead.

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.93%. Comparing base (754a4ac) to head (424ac76).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1123   +/-   ##
=======================================
  Coverage   24.93%   24.93%           
=======================================
  Files         170      170           
  Lines       18239    18239           
=======================================
  Hits         4548     4548           
  Misses      13691    13691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcoconni bcoconni merged commit 651ad3c into JSBSim-Team:master Jul 13, 2024
29 checks passed
@bcoconni
Copy link
Member Author

The PR is immediately pulled to fix the space issue (first item in the PR description) that prevents the CI workflow to run on the Windows/MSVC platform.

@bcoconni bcoconni deleted the ci_workflow branch July 13, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant