Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: for non string keys with some tests / allow uppercase id #110

Merged
merged 2 commits into from
Aug 4, 2016
Merged

Fix: for non string keys with some tests / allow uppercase id #110

merged 2 commits into from
Aug 4, 2016

Conversation

spike83
Copy link
Contributor

@spike83 spike83 commented Aug 4, 2016

  • allow ID to be in upper case (Oracle generates this by default in upper)
  • allow the id be long or decimal (Oracle numbers are mapped to decimal)

Thanks for the nice lib! I'm looking forward to create some more pull requests.
refs: #109 #100

@spike83
Fix:
ca92c19 
- allow ID to be in upper case (Oracle generates this by default in upper)
- allow the id be long or decimal (Oracle numbers are mapped to decimal)
@spike83
Made StringExtensions public it's handy to use in custom NamingConven…
72fc638 
…tion
@csantero csantero merged commit ef5cb3c into JSONAPIdotNET:master Aug 4, 2016
@csantero
Copy link
Collaborator

csantero commented Aug 4, 2016

@spike83 Thanks, looks great!

@csantero csantero mentioned this pull request Aug 4, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spike83 @csantero