Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Protobuf implementation with CBOR #84

Merged
merged 11 commits into from
Apr 12, 2024
Merged

Replace Protobuf implementation with CBOR #84

merged 11 commits into from
Apr 12, 2024

Conversation

Mrgaton
Copy link
Member

@Mrgaton Mrgaton commented Apr 12, 2024

No description provided.

@Mrgaton Mrgaton requested review from inetol and tnfAngel April 12, 2024 13:55
@inetol inetol linked an issue Apr 12, 2024 that may be closed by this pull request
Validation failed, please check our documentation #82
Closed
@Mrgaton
Copy link
Member Author

Mrgaton commented Apr 12, 2024 •
edited
Loading

Tonces hice bien la pull? 😢

inetol
inetol requested changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@inetol inetol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elimina la clase DocumentDataStruct y utiliza solo IDocumentDataStruct para crear la estructura de los documentos, la configuración de interface->class actual es redundante.

@inetol inetol changed the title Cbor x implementation Replace Protobuf implementation with CBOR Apr 12, 2024
@Mrgaton
Copy link
Member Author

Mrgaton commented Apr 12, 2024

Ahora mismo no puedo no sé si podría hacerlo ángel

@inetol inetol self-assigned this Apr 12, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 12, 2024
View reviewed changes
Dockerfile Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 12, 2024
View reviewed changes
Dockerfile Dismissed Show dismissed Hide dismissed
Dockerfile Dismissed Show dismissed Hide dismissed
@inetol inetol self-requested a review April 12, 2024 22:44
@inetol inetol merged commit afad978 into dev Apr 12, 2024
5 checks passed
@inetol inetol deleted the Cbor-x-implementation branch April 12, 2024 22:45
@Mrgaton
Copy link
Member Author

Mrgaton commented Apr 12, 2024

Mi primer pull shark 🥲

@inetol inetol linked an issue Apr 13, 2024 that may be closed by this pull request
Lifetime no se guarda correctamente? #80
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inetol inetol inetol approved these changes

@tnfAngel tnfAngel Awaiting requested review from tnfAngel

Assignees

@inetol inetol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation failed, please check our documentation Lifetime no se guarda correctamente?
3 participants
@Mrgaton @inetol @tnfAngel