Meta: Add protocol and minecraft packages.
#1254
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricoangelon
added
the
Work In Progress
filiphsps
force-pushed
the
master
branch
2 times, most recently
from
ed99c1a
to
18555da
Compare
filiphsps
reviewed
Apr 3, 2024
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "entryPoints": ["src/Updater.ts"] | |||
| } | |||
| @@ -343,7 +343,8 @@ export default class Player extends Human { | |||
| this.gamemode = event.getGamemode(); | |||
| await this.networkSession.sendGamemode(this.gamemode); | |||
|
|
|||
| if (this.gamemode === Gamemode.Creative || this.gamemode === Gamemode.Spectator) this.allowFight = true; | |||
| if (this.gamemode === Gamemode.Gametype.CREATIVE || this.gamemode === Gamemode.Gametype.SPECTATOR) | |||
| this.allowFight = true; | |||
There was a problem hiding this comment.
Brackets. eslint should've caught this.
enricoangelon
force-pushed
the
protocol-package
branch
from
f7593b6
to
15f78a6
Compare
filiphsps
force-pushed
the
master
branch
3 times, most recently
from
1309027
to
d0b8a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a radical change, it adds two packages that simplify the modular import of the software and simplifies its maintenance.
The
minecraftpackage contains the fundamental structures regarding the game logic and some data used by theprismarinepackage.The
protocolpackage instead contains all the structures of the packages contained in the game, and also their possible structures with their own serializations.It will now be possible to import individual packages into external projects without having to import the entire project.