Skip to content

Commit

Permalink
Replace Comments on empty methods with Class wide PMD Annotation
Browse files Browse the repository at this point in the history
Do not enforce checkstyle formatting
  • Loading branch information
manticore-projects committed May 31, 2021
1 parent aa50a91 commit f1fb761
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 39 deletions.
1 change: 0 additions & 1 deletion nb-configuration.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
<com-junichi11-netbeans-changelf.use-global>false</com-junichi11-netbeans-changelf.use-global>
<org-netbeans-modules-javascript2-requirejs.enabled>true</org-netbeans-modules-javascript2-requirejs.enabled>
<netbeans.hint.jdkPlatform>JDK_1.8</netbeans.hint.jdkPlatform>
<netbeans.checkstyle.format>true</netbeans.checkstyle.format>
<org-netbeans-modules-editor-indent.text.xml.CodeStyle.project.expand-tabs>false</org-netbeans-modules-editor-indent.text.xml.CodeStyle.project.expand-tabs>
<org-netbeans-modules-editor-indent.CodeStyle.project.text-line-wrap>none</org-netbeans-modules-editor-indent.CodeStyle.project.text-line-wrap>
<org-netbeans-modules-editor-indent.CodeStyle.project.indent-shift-width>4</org-netbeans-modules-editor-indent.CodeStyle.project.indent-shift-width>
Expand Down
4 changes: 3 additions & 1 deletion pmd-rules.xml
Original file line number Diff line number Diff line change
Expand Up @@ -110,5 +110,7 @@ under the License.

<rule ref="category/java/performance.xml/BigIntegerInstantiation" />
<rule ref="category/java/performance.xml/BooleanInstantiation" />


<!-- for Codazy -->
<rule ref="category/java/documentation.xml/UncommentedEmptyMethodBody" />
</ruleset>
74 changes: 37 additions & 37 deletions src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
*
* <p>Override extractTableName method to modify the extracted table names (e.g. without schema).
*/
@SuppressWarnings({"PMD.CyclomaticComplexity"})
@SuppressWarnings({"PMD.CyclomaticComplexity", "PMD.UncommentedEmptyMethodBody"})
public class TablesNamesFinder implements SelectVisitor, FromItemVisitor, ExpressionVisitor, ItemsListVisitor, SelectItemVisitor, StatementVisitor {

private static final String NOT_SUPPORTED_YET = "Not supported yet.";
Expand Down Expand Up @@ -244,7 +244,7 @@ public void visit(IntegerDivision division) {

@Override
public void visit(DoubleValue doubleValue) {
// intentional (commented) empty methods.

}

@Override
Expand Down Expand Up @@ -288,7 +288,7 @@ public void visit(InExpression inExpression) {

@Override
public void visit(FullTextSearch fullTextSearch) {
// intentional (commented) empty methods.

}

@Override
Expand All @@ -298,17 +298,17 @@ public void visit(SignedExpression signedExpression) {

@Override
public void visit(IsNullExpression isNullExpression) {
// intentional (commented) empty methods.

}

@Override
public void visit(IsBooleanExpression isBooleanExpression) {
// intentional (commented) empty methods.

}

@Override
public void visit(JdbcParameter jdbcParameter) {
// intentional (commented) empty methods.

}

@Override
Expand All @@ -323,7 +323,7 @@ public void visit(ExistsExpression existsExpression) {

@Override
public void visit(LongValue longValue) {
// intentional (commented) empty methods.

}

@Override
Expand All @@ -348,7 +348,7 @@ public void visit(NotEqualsTo notEqualsTo) {

@Override
public void visit(NullValue nullValue) {
// intentional (commented) empty methods.

}

@Override
Expand All @@ -363,7 +363,7 @@ public void visit(Parenthesis parenthesis) {

@Override
public void visit(StringValue stringValue) {
// intentional (commented) empty methods.

}

@Override
Expand Down Expand Up @@ -407,17 +407,17 @@ public void visit(NamedExpressionList namedExpressionList) {

@Override
public void visit(DateValue dateValue) {
// intentional (commented) empty methods.

}

@Override
public void visit(TimestampValue timestampValue) {
// intentional (commented) empty methods.

}

@Override
public void visit(TimeValue timeValue) {
// intentional (commented) empty methods.

}

/*
Expand Down Expand Up @@ -510,7 +510,7 @@ public void visit(Modulo modulo) {

@Override
public void visit(AnalyticExpression analytic) {
// intentional (commented) empty methods.

}

@Override
Expand All @@ -522,7 +522,7 @@ public void visit(SetOperationList list) {

@Override
public void visit(ExtractExpression eexpr) {
// intentional (commented) empty methods.

}

@Override
Expand All @@ -539,7 +539,7 @@ public void visit(MultiExpressionList multiExprList) {

@Override
public void visit(ValuesList valuesList) {
// intentional (commented) empty methods.

}

/**
Expand All @@ -558,12 +558,12 @@ protected void init(boolean allowColumnProcessing) {

@Override
public void visit(IntervalExpression iexpr) {
// intentional (commented) empty methods.

}

@Override
public void visit(JdbcNamedParameter jdbcNamedParameter) {
// intentional (commented) empty methods.

}

@Override
Expand All @@ -589,22 +589,22 @@ public void visit(RegExpMySQLOperator rexpr) {

@Override
public void visit(JsonExpression jsonExpr) {
// intentional (commented) empty methods.

}

@Override
public void visit(JsonOperator jsonExpr) {
// intentional (commented) empty methods.

}

@Override
public void visit(AllColumns allColumns) {
// intentional (commented) empty methods.

}

@Override
public void visit(AllTableColumns allTableColumns) {
// intentional (commented) empty methods.

}

@Override
Expand All @@ -614,23 +614,23 @@ public void visit(SelectExpressionItem item) {

@Override
public void visit(UserVariable var) {
// intentional (commented) empty methods.

}

@Override
public void visit(NumericBind bind) {

// intentional (commented) empty methods.

}

@Override
public void visit(KeepExpression aexpr) {
// intentional (commented) empty methods.

}

@Override
public void visit(MySQLGroupConcat groupConcat) {
// intentional (commented) empty methods.

}

@Override
Expand Down Expand Up @@ -774,7 +774,7 @@ public void visit(RowConstructor rowConstructor) {
@Override
public void visit(HexValue hexValue) {

// intentional (commented) empty methods.

}

@Override
Expand All @@ -789,12 +789,12 @@ public void visit(Merge merge) {

@Override
public void visit(OracleHint hint) {
// intentional (commented) empty methods.

}

@Override
public void visit(TableFunction valuesList) {
// intentional (commented) empty methods.

}

@Override
Expand All @@ -804,19 +804,19 @@ public void visit(AlterView alterView) {

@Override
public void visit(TimeKeyExpression timeKeyExpression) {
// intentional (commented) empty methods.

}

@Override
public void visit(DateTimeLiteralExpression literal) {

// intentional (commented) empty methods.

}

@Override
public void visit(Commit commit) {

// intentional (commented) empty methods.

}

@Override
Expand All @@ -832,7 +832,7 @@ public void visit(Upsert upsert) {

@Override
public void visit(UseStatement use) {
// intentional (commented) empty methods.

}

@Override
Expand Down Expand Up @@ -877,7 +877,7 @@ public void visit(ExplainStatement explain) {

@Override
public void visit(NextValExpression nextVal) {
// intentional (commented) empty methods.

}

@Override
Expand All @@ -887,7 +887,7 @@ public void visit(CollateExpression col) {

@Override
public void visit(ShowStatement aThis) {
// intentional (commented) empty methods.

}

@Override
Expand All @@ -897,13 +897,13 @@ public void visit(SimilarToExpression expr) {

@Override
public void visit(DeclareStatement aThis) {
// intentional (commented) empty methods.

}

@Override
public void visit(Grant grant) {

// intentional (commented) empty methods.

}

@Override
Expand Down Expand Up @@ -955,7 +955,7 @@ public void visit(VariableAssignment var) {

@Override
public void visit(XMLSerializeExpr aThis) {
// intentional (commented) empty methods.

}

@Override
Expand Down

0 comments on commit f1fb761

Please sign in to comment.