Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special oracle tests #1279

Merged
merged 9 commits into from
Aug 9, 2021
Merged

Conversation

manticore-projects
Copy link
Contributor

@manticore-projects manticore-projects commented Jul 21, 2021

The SpecialOracle Test succeeded when a new feature fixed more samples than it broke.
We lost GROUPING(), LINK this way.

Furthermore it was very difficult to read a particular Test Case and to understand, what was actually expected and working or not.
Last but not least, this test was very noisy.

Implemented Changes:

  1. Implemented GROUPING(), LINK keywords correctly (this fixed a bunch of tests)
  2. Implemented ParenthesisFromItem Pivot and UnPivot correctly (this fixed a few more tests)
  3. Write the expected Test Result directly into the Test SQL source file
  4. Updated the List of Tests expected to succeed and will fail when any of these suddenly fails (no sacrifices please!)
  5. Warn only when anything unexpected happens (e. g. Newly achieved Success)

In the result, now 186 out of 272 tests succeed (almost 10 more than before).
Fixes #1201.

Reduce the noise during the test
Update/correct the list of expected passing files
Get the benchmark from the list of expected passing files
Fail the test when any expected success suddenly fails
@coveralls
Copy link

coveralls commented Jul 21, 2021

Coverage Status

Coverage increased (+0.003%) to 88.755% when pulling 61c37b8 on manticore-projects:SpecialOracleTests into d662484 on JSQLParser:master.

@manticore-projects
Copy link
Contributor Author

Something is still wrong with the SelectDeparser and ParenthesisFromItem Pivots or UnPivots:

  • Pivot seems to be deparsed already somewhere else
  • UnPivot is not deparsed somewhere else and so needed to be added (although I likely added them at the wrong place)

Right now, I got it working somehow but someone else should have an eye onto it.
I do not work with the Visitor patterns, they are confusing me.

…racleTests

Conflicts:
	src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
@manticore-projects
Copy link
Contributor Author

The change works beautifully: When synchronizing it against the merged PURGE PR, suddenly an exception about bindvar05.sql has been thrown and pointed me on declaring RECEYCLEBIN as valid Object Name.

This has not been detected in PURGE PR itself, where it belonged to.

@wumpz
Copy link
Member

wumpz commented Aug 2, 2021

Is this PR still valid with all these conflicts?

…racleTests

Conflicts:
	src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
	src/test/java/net/sf/jsqlparser/statement/select/SpecialOracleTest.java
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/aggregate01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/analytic_query02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/analytic_query03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/analytic_query04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/analytic_query05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/analytic_query06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/analytic_query07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/analytic_query08.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/analytic_query09.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/analytic_query10.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/bindvar01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/bindvar02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/bindvar03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/bindvar04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/bindvar05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/case_when01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/case_when02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/case_when03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/case_when04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/case_when05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset08.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset09.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset10.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset11.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset12.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset13.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset14.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset15.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset16.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset17.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset18.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset19.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset20.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset21.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset22.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset23.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset24.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset25.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset26.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset27.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset28.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset29.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset30.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset31.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset32.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset33.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset34.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset35.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset36.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset37.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset38.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset39.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset40.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset41.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset42.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cast_multiset43.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/cluster_set01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/columns01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition08.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition09.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition10.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition11.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition12.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition14.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition15.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition16.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition17.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition18.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition19.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/condition20.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/connect_by01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/connect_by02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/connect_by03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/connect_by04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/connect_by05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/connect_by06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/connect_by07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/datetime01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/datetime02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/datetime03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/datetime04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/datetime05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/datetime06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/dblink01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/explain01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/flashback01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/for_update01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/for_update02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/for_update03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/for_update04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/for_update05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/for_update06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/for_update07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/for_update08.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/function01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/function02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/function03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/function04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/function05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/function06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/function07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby08.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby09.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby10.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby11.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby12.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby13.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby14.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby15.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby16.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby17.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby18.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby19.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby20.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby21.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby22.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/groupby23.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/insert01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/insert02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/insert03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/insert04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/insert05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/insert06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/insert07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/insert08.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/insert09.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/insert10.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/insert11.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/insert12.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/interval01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/interval02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/interval03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/interval04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/interval05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join08.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join09.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join10.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join11.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join12.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join13.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join14.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join15.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join16.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join17.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join18.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join19.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join20.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/join21.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/keywordasidentifier01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/keywordasidentifier02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/keywordasidentifier03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/keywordasidentifier04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/keywordasidentifier05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/lexer01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/lexer02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/lexer03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/lexer04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/lexer05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/like01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/loop01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/loop02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/merge01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/merge02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/merge03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/merge04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause08.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause09.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause10.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause11.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause12.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause13.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause14.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause15.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/model_clause16.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/numbers01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/object_access01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/order_by01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/order_by02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/order_by03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/order_by04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/order_by05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/order_by06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/pivot01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/pivot02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/pivot03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/pivot04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/pivot05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/pivot06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/pivot07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/pivot08.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/pivot09.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/pivot10.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/pivot11.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/pivot12.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring08.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring09.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring10.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring11.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring12.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring13.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/query_factoring14.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/returning01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/sample01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/set01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/set02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/simple02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/simple03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/simple04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/simple05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/simple06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/simple07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/simple08.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/simple09.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/simple10.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/simple11.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/simple12.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/simple13.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/string01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/union01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/union02.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/union03.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/union04.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/union05.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/union06.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/union07.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/union08.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/union09.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/union10.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/xmltable01.sql
	src/test/resources/net/sf/jsqlparser/statement/oracle-tests/xmltable02.sql
@manticore-projects
Copy link
Contributor Author

Is this PR still valid with all these conflicts?

Very valid and beautiful :-D
We could add similar SQL Batch tests for other RDBMS as well with this improved infrastructure.

@wumpz wumpz merged commit 346eea5 into JSQLParser:master Aug 9, 2021
@manticore-projects manticore-projects deleted the SpecialOracleTests branch May 31, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpecialOracleTest currently creates a lot of noise
3 participants