Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted Fixes #7 #1745

Merged
merged 42 commits into from Mar 21, 2023
Merged

Conversation

zaza and others added 30 commits December 11, 2022 21:03
…RESH

Support parsing create view statements in Redshift with AUTO REFRESH
option.
Extract adding the force option into a dedicated method resulting in the
cyclomatic complexity reduction of the CreateView.toString method.
Add Keywords and document, which keywords are allowed for what purpose
Derive All Keywords from Grammar directly
Generate production for Object Names (semi-) automatically
Add parametrized Keyword Tests
Parallel Test execution
Gradle Caching
Explicitly request for latest JavaCC 7.0.10
Parallel Test execution
Gradle Caching
Explicitly request for latest JavaCC 7.0.10
Update the MANTICORE Sphinx Theme, but ignore it in GIT
Add the content to the Sphinx sites
Add a Gradle function to derive Stable and Snapshot version from GIT Tags
Add a Gradle GIT change task
Add a Gradle sphinx task
Add a special Test case for illustrating the use of JSQLParser
Implement Serializable for persisting via ObjectOutputStream
- apply neutral Sphinx theme
- insert the RR diagrams into the sphinx sources
- better documentation on Gradle dependencies
- link GitHub repository
- add support for Oracle Alternative Quoting e.g. `q'(...)'`
- fixes JSQLParser#1718
- add a Logo and FavIcon to the Website
- document recent changes on Quoting/Escaping
- add an example on building SQL from Java
- rework the README.md, promote the Website
- add Spotless Formatter, using Google Java Style (with Tab=4 Spaces)
- fix the issue template
- fix the -SNAPSHOT version number
- `GO`
- Slash `/`
- Two empty lines
- `FETCH` uses `EXPRESSION` instead of SimpleJDBCParameter only
- Visit/Accept `FETCH` `EXPRESSION` instead of `append` to String
- Visit/Accept `OFFSET` `EXPRESSION` instead of `append` to String
- Gradle: remove obsolete/incompatible `jvmArgs` from Test()
@manticore-projects manticore-projects changed the title Json operator issue1571 Assorted Fixes #7 Mar 20, 2023
Copy link
Member

@wumpz wumpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however I will merge

@@ -85,8 +86,8 @@ dependencies {
testImplementation 'org.mockito:mockito-junit-jupiter:4.+'

// enforce latest version of JavaCC
testImplementation 'net.java.dev.javacc:javacc:7.0.12'
javacc 'net.java.dev.javacc:javacc:7.0.12'
testImplementation 'net.java.dev.javacc:javacc:+'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In history we had problems using the latest version.

@@ -10,8 +10,8 @@
package net.sf.jsqlparser.statement;

import java.io.Serializable;
import java.util.ArrayList;
import java.util.List;
import java.util.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using wildcard imports is a bad practice. More than needed is imported and could potentially link unneeded modules to the library.

@wumpz wumpz merged commit 31ef1aa into JSQLParser:master Mar 21, 2023
3 checks passed
@manticore-projects manticore-projects deleted the JSonOperatorIssue1571 branch April 29, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment